x86: physdev_[un]map_pirq() use rcu_lock_target_domain_by_id().

More idiomatic, and avoids accidental failure to check caller
privilege. For example, the unmap path was not checking for any
privilege before calling unmap_domain_pirq_emuirq(), which can't be
right.

Signed-off-by: Keir Fraser <keir@xen.org>

diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c
index 5e0bbe174b7a5be7b87cb62b470e55309daaf5f1..3454c03e0357eaaf5ef1e0e2fa76a181f5096b91 100644 (file)
--- a/xen/arch/x86/physdev.c
+++ b/xen/arch/x86/physdev.c
@@ -87,14 +87,9 @@ static int physdev_map_pirq(struct physdev_map_pirq *map)
     struct msi_info _msi;
     void *map_data = NULL;
 
-    if ( !map )
-        return -EINVAL;
-
-    d = (map->domid == DOMID_SELF) ? rcu_lock_current_domain()
-        : rcu_lock_domain_by_id(map->domid);
-
-    if ( d == NULL )
-        return -ESRCH;
+    ret = rcu_lock_target_domain_by_id(map->domid, &d);
+    if ( ret )
+        return ret;
 
     if ( map->domid == DOMID_SELF && is_hvm_domain(d) )
     {
@@ -225,11 +220,9 @@ static int physdev_unmap_pirq(struct physdev_unmap_pirq *unmap)
     struct domain *d;
     int ret;
 
-    d = (unmap->domid == DOMID_SELF) ? rcu_lock_current_domain()
-        : rcu_lock_domain_by_id(unmap->domid);
-
-    if ( d == NULL )
-        return -ESRCH;
+    ret = rcu_lock_target_domain_by_id(unmap->domid, &d);
+    if ( ret )
+        return ret;
 
     if ( is_hvm_domain(d) )
     {